-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified Installer #459
Modified Installer #459
Conversation
…ses box lines instead of hyphens
doc. Here docs are more efficient as they only call once, and formatting doesn't need to be done with escape characters, thus making code more readable
Very nice, I actually wanted to do this myself but never got around it. Two things: As from what I understood this doesn't happen for you? If I re-run the same command on new re-sized terminal width then line will be adjusted.
But I guess it's related to what I proposed in 4 as this stuff is used outside of installer
|
Well, lines that are already drawn will not resize, but yes, running the command again in a resized terminal will adjust to the size.
I uh... didn't see that. I'll make some commits and fix those, they will probably use the same logic as the install heading 😄
Will do
The only problem with that is that I don't know python very well.... I usually program in c and make small shell scripts. It shouldn't be too hard though. I'll keep you informed if I cannot do it |
If it helps, there's even a snippet that will take care of terminal sizing/padding but was never merged with |
Moved $COLOUMN into seperator function, so if the terminal is resized while the script is running, a new seperator should be resized as well.
multiple times. Made local variables to allow for neat drawing when resizing the terminal.
Definitely a good idea, since there will be lot more changes and it'll be a lot bigger PR.
Let's please return these to
Also let's add an empty line before "Welcome to ..."
Most welcome, I'm honored to make your first PR a pleasant experience and too many more! 🍻 |
Done They also dynamically size just like the seperator:
Thanks again :D. |
I've just noticed a regression introduced as part of #460, so let's resolve this first before this PR is merged. |
I was about to merge these changes, but then I found out what was missing as part of #462, I won't revert the changes so maybe it's easiest to make the changes as part of this PR? Currently, if you do
|
Okay, will do.
Okay, I'll keep the error, but remove the other files.... |
New PR merged
…the daemon needing to be installed
the I also added a check for the wrapper script, so it should just work now |
Perfect! Thank you for your contribution and I'm making to be making a v1.9.7 release where you'll get credit for all your work :) |
Fixed some formatting for the installer and lessened the number of echo calls with here docs, etc.
Now, seperators are done properly, to the width of the terminal and are proper box dashes (as per the Unicode specification):
Adjusting the size adjusts the bar: